https://github.com/rsandifo-arm commented:
Thanks for the update, looks great to me. The only substantive comment I have is that I think a given keyword attribute must always take `(` and `)` or never take them. It shouldn't be optional, because that risks creating parsing ambiguities, or at least non-obvious behaviour. https://github.com/llvm/llvm-project/pull/76971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
