pizzud wrote: > I cleaned up the reviewers. I suggest to use `git merge` next time you need > to bring your PR up to date with `main`. We are not worried about merge > commits, as squash is the only available merge option for PRs. >
Thanks! I'll try merge next time. > I also suggest to use "Start review" button when you respond to multiple > comments, as that reduces amount of e-mail notifications. Start review seems weird since the review is already in flight and I think I'd have to revert to draft in between - the button isn't currently visible. If it's less spammy I'm okay with it, though. I'm also used to a code review tool where the comments get batched into drafts and then you publish them all together when you have new code. https://github.com/llvm/llvm-project/pull/67467 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
