mgorny planned changes to this revision. mgorny added inline comments.
================ Comment at: unittests/Driver/ToolChainsTest.cpp:15 +// FIXME: I presume this is not the correct way of doing this +#include "../lib/Driver/ToolChains.h" +#include "clang/Basic/VirtualFileSystem.h" ---------------- bkramer wrote: > Yeah. It's better to hoist the enum + the decl for detectDistro into a public > header under include/clang/Driver and include it from here. Ok. Then I'll probably refactor the whole thing into a nicer API anyway ;-). https://reviews.llvm.org/D25869 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
