https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/78859
User-defined literals do not accept u?intXX(_t)? variables. So the check should
not emit a warning.
Fixes #54546 #25214
From 8ea205ae2324d67f9adaf30d5662d2cde2096534 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
<felix-antoine.constan...@polymtl.ca>
Date: Sat, 20 Jan 2024 15:29:06 -0500
Subject: [PATCH] [clang-tidy] Ignore user-defined literals in
google-runtime-int
User-defined literals do not accept u?intXX(_t)? variables.
So the check should not emit a warning.
Fixes #54546 #25214
---
.../clang-tidy/google/IntegerTypesCheck.cpp | 13 ++++++++-----
clang-tools-extra/docs/ReleaseNotes.rst | 3 +++
.../test/clang-tidy/checkers/google/runtime-int.cpp | 10 ++++++----
3 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp
b/clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp
index bb4e1de8cc4b15..b60f2d0ed63112 100644
--- a/clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp
+++ b/clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp
@@ -56,11 +56,14 @@ void IntegerTypesCheck::registerMatchers(MatchFinder
*Finder) {
// http://google.github.io/styleguide/cppguide.html#64-bit_Portability
// "Where possible, avoid passing arguments of types specified by
// bitwidth typedefs to printf-based APIs."
- Finder->addMatcher(typeLoc(loc(isInteger()),
- unless(hasAncestor(callExpr(
-
callee(functionDecl(hasAttr(attr::Format)))))))
- .bind("tl"),
- this);
+ Finder->addMatcher(
+ typeLoc(loc(isInteger()),
+ unless(anyOf(hasAncestor(callExpr(
+ callee(functionDecl(hasAttr(attr::Format))))),
+ hasParent(parmVarDecl(hasAncestor(functionDecl(
+ matchesName("operator\"\".*$"))))))))
+ .bind("tl"),
+ this);
IdentTable = std::make_unique<IdentifierTable>(getLangOpts());
}
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index a235a7d02592e8..5c857824c2b021 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -359,6 +359,9 @@ Changes in existing checks
to ignore unused parameters when they are marked as unused and parameters of
deleted functions and constructors.
+- Improved :doc:`google-runtime-int` check to ignore
+ false positives on user defined-literals.
+
- Improved :doc:`llvm-namespace-comment
<clang-tidy/checks/llvm/namespace-comment>` check to provide fixes for
``inline`` namespaces in the same format as :program:`clang-format`.
diff --git a/clang-tools-extra/test/clang-tidy/checkers/google/runtime-int.cpp
b/clang-tools-extra/test/clang-tidy/checkers/google/runtime-int.cpp
index 4bb739876b7f4c..88f0b519e9cbee 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/google/runtime-int.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/google/runtime-int.cpp
@@ -59,11 +59,13 @@ void qux() {
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: consider replacing 'short' with
'int16'
}
-// FIXME: This shouldn't warn, as UD-literal operators require one of a handful
-// of types as an argument.
struct some_value {};
-constexpr some_value operator"" _some_literal(unsigned long long int i);
-// CHECK-MESSAGES: [[@LINE-1]]:47: warning: consider replacing 'unsigned long
long'
+constexpr some_value operator"" _some_literal(unsigned long long int i)
+{
+ short j;
+ // CHECK-MESSAGES: [[@LINE-1]]:3: warning: consider replacing 'short' with
'int16'
+ return some_value();
+}
struct A { A& operator=(const A&); };
class B { A a[0]; };
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
