11happy wrote: ``` if (isa<clang::ImplicitCastExpr>(S) && !found) { const auto CastKind = cast<clang::ImplicitCastExpr>(S)->getCastKind(); if (isImplicitCastType(CastKind)) { found = true; const clang::ImplicitCastExpr *ImplicitCast = cast<clang::ImplicitCastExpr>(S); GlobalImplicitCastType = ImplicitCast->getType(); // Stop visiting children. return false; } } ``` these two Ifs can be clubbed into single one , as suggested insome previous style suggestions, but I have kept them to ensure better readability. should I club them?
https://github.com/llvm/llvm-project/pull/77816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits