pileghoff wrote:

> Thank you for the Fix! Your summary should be a description of the problem 
> and how your solution fixes that problem. You should also link to the github 
> issue in the summary.
> 
> Questions about the changes in the PR should go as a comment to the PR.
> 
> Please add a release note and this will need tests as well.

Noted. I have updated the description.

With regards to testing, I think I get how to write them, but I'm still unsure 
about where I'm suppose to put them. Would a new file 
(`implicit-boolike-conversion.c`?) be appropriate? 

Is the PR requirements/process documented anywhere? I had a look at 
[here](https://llvm.org/docs/Contributing.html) and i was looking around if 
there was a template, but i have found nothing.

https://github.com/llvm/llvm-project/pull/79588
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to