llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) <details> <summary>Changes</summary> Default value of checker option `ModelPOSIX` is changed to `true`. Documentation is updated. --- Full diff: https://github.com/llvm/llvm-project/pull/80457.diff 3 Files Affected: - (modified) clang/docs/analyzer/checkers.rst (+15-4) - (modified) clang/include/clang/StaticAnalyzer/Checkers/Checkers.td (+1-1) - (modified) clang/test/Analysis/analyzer-config.c (+1-1) ``````````diff diff --git a/clang/docs/analyzer/checkers.rst b/clang/docs/analyzer/checkers.rst index bb637cf1b8007..24522e56501e5 100644 --- a/clang/docs/analyzer/checkers.rst +++ b/clang/docs/analyzer/checkers.rst @@ -1299,10 +1299,21 @@ range of the argument. **Parameters** -The checker models functions (and emits diagnostics) from the C standard by -default. The ``ModelPOSIX`` option enables modeling (and emit diagnostics) of -additional functions that are defined in the POSIX standard. This option is -disabled by default. +The ``ModelPOSIX`` option controls if functions from the POSIX standard are +recognized by the checker. If ``true``, a big amount of POSIX functions is +modeled according to the +`POSIX standard`_. This +includes ranges of parameters and possible return values. Furthermore the +behavior related to ``errno`` in the POSIX case is often that ``errno`` is set +only if a function call fails, and it becomes undefined after a successful +function call. +If ``false``, functions are modeled according to the C99 language standard. +This includes far less functions than the POSIX case. It is possible that the +same functions are modeled differently in the two cases because differences in +the standards. The C standard specifies less aspects of the functions, for +example exact ``errno`` behavior is often unspecified (and not modeled by the +checker). +Default value of the option is ``true``. .. _osx-checkers: diff --git a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td index e7774e5a9392d..a224b81c33a62 100644 --- a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td +++ b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td @@ -578,7 +578,7 @@ def StdCLibraryFunctionsChecker : Checker<"StdCLibraryFunctions">, "ModelPOSIX", "If set to true, the checker models additional functions " "from the POSIX standard.", - "false", + "true", InAlpha> ]>, WeakDependencies<[CallAndMessageChecker, NonNullParamChecker]>, diff --git a/clang/test/Analysis/analyzer-config.c b/clang/test/Analysis/analyzer-config.c index 373017f4b18bf..2167a2b32f596 100644 --- a/clang/test/Analysis/analyzer-config.c +++ b/clang/test/Analysis/analyzer-config.c @@ -129,7 +129,7 @@ // CHECK-NEXT: unix.DynamicMemoryModeling:Optimistic = false // CHECK-NEXT: unix.Errno:AllowErrnoReadOutsideConditionExpressions = true // CHECK-NEXT: unix.StdCLibraryFunctions:DisplayLoadedSummaries = false -// CHECK-NEXT: unix.StdCLibraryFunctions:ModelPOSIX = false +// CHECK-NEXT: unix.StdCLibraryFunctions:ModelPOSIX = true // CHECK-NEXT: unroll-loops = false // CHECK-NEXT: verbose-report-filename = false // CHECK-NEXT: widen-loops = false `````````` </details> https://github.com/llvm/llvm-project/pull/80457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
