================
@@ -3342,6 +3342,18 @@ bool Expr::isConstantInitializer(ASTContext &Ctx, bool 
IsForRef,
     if (ILE->getType()->isRecordType()) {
       unsigned ElementNo = 0;
       RecordDecl *RD = ILE->getType()->castAs<RecordType>()->getDecl();
+
+      // Check bases for C++17 aggregate initializers.
----------------
shafik wrote:

Should we be checking `CPlusPlus17` here? 

Also I would like to see a standard quote in the comments. I know we are not 
doing this locally but these are really helpful and we should be doing this 
more consistently.

https://github.com/llvm/llvm-project/pull/80519
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to