[clang] [dataflow] CXXOperatorCallExpr equal operator might not be a glvalue (PR #80991)

[via cfe-commits]

================
@@ -535,7 +535,19 @@ class TransferVisitor : public 
ConstStmtVisitor<TransferVisitor> {
         return;
 
       copyRecord(*LocSrc, *LocDst, Env);
-      Env.setStorageLocation(*S, *LocDst);
+
+      // If the expr is a glvalue, we can reasonably assume the operator is
+      // returning T& and thus we can assign it `LocDst`.
+      if (S->isGLValue()) {
+        Env.setStorageLocation(*S, *LocDst);
+      } else if (S->getType()->isRecordType() && S->isPRValue()) {
----------------
martinboehme wrote:

```suggestion
      } else if (S->getType()->isRecordType()) {
```

`S->isPRValue()` is redundant here because `S->isPRValue() == !S->isGLValue()`.

https://github.com/llvm/llvm-project/pull/80991
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits