aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM, modulo a small commenting request. ================ Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242 +struct IncompleteType; +void NegativeForIncompleteType(IncompleteType I) { + // CHECK-MESSAGES: [[@LINE-1]]:47: error: variable has incomplete type 'IncompleteType' [clang-diagnostic-error] ---------------- You should put a comment before this function that explains why this seemingly-incongruous test lives here. Something along the lines of "Ensure that incomplete types result in an error from the frontend and not a clang-tidy diagnostic about IncompleteType being expensive to copy." https://reviews.llvm.org/D26195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits