craig.topper added inline comments.
================ Comment at: test/Preprocessor/x86_target_features.c:212 +// RUN: %clang -target i386-unknown-unknown -march=atom -mavx512vbmi -mno-avx512vbmi -x c -E -dM -o - %s | FileCheck -match-full-lines --check-prefix=AVX512VBMINOAVX512BW %s + ---------------- zvi wrote: > Test is turning on and then off the same feature. Did you mean -mavx512bw > -mno-avx512vbmi ? > > If the latter, I would prefer the compiler shout at me for providing > contradicting flags than let the last flag win. Consider enforcing this in > handleTargetFeatures(). > > It was supposed to be -mavx512vbmi -mno-avx512bw to verify that turning off bwi would turn off vbmi. The lack of warning is consistent with the behavior of all the other linked feature flags. https://reviews.llvm.org/D26306 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
