alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One nit. Otherwise looks good. Thank you!
================
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- header_guard_new = module.upper() + '_' +
check_name_new.upper().replace('-', '_')
+ header_guard_old = args.module.upper() + '_' + \
+ args.old_check_name.upper().replace('-', '_')
----------------
Does PEP8 have any preferences with regard to using a terminating backslash
over enclosing an expression that needs to be wrapped in parentheses? If no,
I'd better use parentheses.
https://reviews.llvm.org/D25074
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
