owenca wrote: > LGTM, as long as someone doesn't say it should be > > ```c++ > #if FOO > constexpr > #endif > inline > int i = 0; > ``` > > but I think this change is fine..I would rather we didn't try and support > that.. thank you.
Yep! Otherwise, you would have to handle the following, given that the order is `[const, inline, constexpr, type]`: ```c++ inline #if FOO constexpr /* foo */ #else const /* bar */ #endif int i = 0; ``` https://github.com/llvm/llvm-project/pull/81958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits