NagyDonat wrote:

That sounds reasonable. Unfortunately I don't know much about the context of 
this change, so let's wait for a review from @danix800 (or somebody else who's 
knows enough) before merging this change.

Also, perhaps it would be a good idea to add a testcase (or a few of them) in 
the directory `clang/test/Analysis` to prevent regressions and illustrate the 
goals of this change. (As far as I know our test system is just a heap of 
random C/C++ files with a "how to compile/analyze this" header and "what 
warnings/errors should appear" markers in comments. I usually add testcases by 
following the example of older analogous cases.)

https://github.com/llvm/llvm-project/pull/82089
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to