haoNoQ wrote: Hmm, no, I landed it because I made an assumption that there's simply not that much interest in this work (I'm quite depressed about this in general lately) so as a code owner I just made a call that it's probably good enough to go and rely on post-commit review. Now that you bring this up, it does sound a lot like I should get myself out of this mindset and at least ping people first. Especially Erich who I specifically invited as the code owner of clang attributes. Absolutely my bad. I definitely see how this isn't great moving forward and I will do better from now on. Should I also revert and give you folks time to properly review and course-correct me?
https://github.com/llvm/llvm-project/pull/80371 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
