aaron.ballman added a comment. In https://reviews.llvm.org/D25659#589386, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > > > I think, silently choosing one of the checks may be confusing and > > counter-intuitive. Should we just warn in case we see the same check > > enabled by multiple aliases? > > > A warning is useful if the checks have different settings, e.g. > google-readability-braces-around-statements and > readability-braces-around-statements. > > But a warning is just noise for other aliases, e.g. cert-dcl54-cpp and > misc-new-delete-overloads. That's why I don't think there's a good default behavior without capturing further information about whether an alias is an identical copy under a different name or a partial copy with differing semantics. If we have that information, then my preference is for warning the user about enabling the (effectively) same check twice. https://reviews.llvm.org/D25659 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
