aaron.ballman added inline comments.

================
Comment at: clang-tidy/misc/DeleteNullPointerCheck.cpp:54
+      diag(IfWithDelete->getLocStart(),
+           "if statement is unnecessary (deleting null pointer has no 
effect)");
+  std::string ReplacementText = Lexer::getSourceText(
----------------
Rather than a parenthetical, I would just use a semicolon to distinguish the 
clauses. Also, I would quote 'if' to make it clear that you're talking about 
syntax rather than an English term.


================
Comment at: clang-tidy/misc/DeleteNullPointerCheck.h:19
+
+/// FIXME: Write a short description.
+///
----------------
You should write that short description.


https://reviews.llvm.org/D21298



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to