MaskRay wrote:
Created #83497 as a follow-up to suppress the diagnostic for certain template
instantiation uses.
I made one change to unblock our internal users
```
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpointer-bool-conversion"
#endif
// functor_ may be a lambda, which is convertible to bool, leading to a
// -Wpointer-bool-conversion warning because the value is always true.
return functor_ == nullptr;
#ifdef __clang__
#pragma clang diagnostic pop
#endif
```
and then (when I saw another instance of wrapping a callable object) realized
we probably should suppress the diagnostic for instantiation. This is similar
to how we suppress the diagnostic for instantiations for -Wtautological-compare
https://github.com/llvm/llvm-project/pull/83152
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
