WenleiHe wrote: > > LGTM. I'd also have a change that errors out on huge staleness go in > > together with this one.. > > Was thinking to use a separate diff for that, feels non-trivial to do it, but > I'm also good for doing in this. > > Just pushed one version for this, it use heuristics to check this, note that > the current threshold flags is just based my "gut feeling", so I'm going to > tune those flags on our internal services, hope that we can achieve the goal: > > 1. Use the current prod profile, so all build should pass without any false > positives break. > 2. Use the incompatible profile, so all build should error out. > > Any early feedback is appreciated.
Sorry I wasn't clear. The error out change should be a separate patch as logically it's independent of the original mix order change. By go in together, I was mostly thinking about two patches that go in together.. https://github.com/llvm/llvm-project/pull/75092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
