Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath <horvath.botond.ist...@gmail.com>,Botond Istvan Horvath <horvath.botond.ist...@gmail.com>,Botond Istvan Horvath <horvath.botond.ist...@gmail.com>,Botond Istvan Horvath <horvath.botond.ist...@gmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/83...@github.com>
Endilll wrote: > I have added tests to other files what are relevant for the DR too. Should I > move them here? I trust your judgement here. Your PR touches a topic complicated enough that I don't feel qualified to make the judgement myself. My stance is that DR should be considered narrow in scope. So if you think that your additional tests are directly related to what the DR is about, go ahead. For instance, when DR is about cv-qualifiers in variable declarations, but the provided examples only cover `const`, I consider additional test for `volatile` to be directly related. On the other hand, if during implementation you realize that something is going on with cv-qualifiers on non-static member functions, and you want to test that, then it's a related issue, but not a part of the DR. In my view, DR test suite prioritizes being on spot more than just containing sheer volume of tests. https://github.com/llvm/llvm-project/pull/83279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
