yaxunl marked 12 inline comments as done. yaxunl added inline comments.
================ Comment at: lib/CodeGen/TargetInfo.cpp:7040 + auto AS = PT->getAddressSpace(); + return AS != Ctx.getTargetAddressSpace(LangAS::opencl_local) && AS != 0; +} ---------------- rjmccall wrote: > This check is definitely not correct; this function needs to return true when > AS == 0, right? > > Also, you should really just be checking QT.getAddressSpace(). The null pointer of amdgpu target in addr space 0 does not have zero value. I will change it use QT.getAddressSpace() though. https://reviews.llvm.org/D26196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
