I think you can go ahead and commit it, yes. Alex
On 11 November 2016 at 05:28, Serge Pavlov <sepavl...@gmail.com> wrote: > Is it OK to commit this patch? > > Thanks, > --Serge > > 2016-10-21 18:21 GMT+07:00 Alex Lorenz <arpha...@gmail.com>: > >> arphaman added a subscriber: rsmith. >> arphaman added a comment. >> >> LGTM, I added Richard in case he has something to add. >> >> > I chose to retain current clang behavior and reject questionable code. >> GCC patch that introduced this message explains using warning by some >> uncertainty, 5 years passed, I think the standard is stable in viewpoint on >> such usage. >> >> Thanks for the detailed explanation, I wasn't sure if GCC's was behaving >> according to the standard or not. >> >> >> https://reviews.llvm.org/D25816 >> >> >> >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits