pcc added a comment.

Test case?



================
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+  EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+                CallLoc, This, C.getRecordType(DD->getParent()));
----------------
Is it correct to emit a type check at this point? Looking at [0] it looks like 
this function is only called from the Microsoft C++ ABI after we have already 
resolved the virtual function pointer.

[0] 
http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGExprCXX.cpp/rEmitCXXDestructorCall


https://reviews.llvm.org/D26559



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to