llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Diego A. Estrada Rivera (diego-est) <details> <summary>Changes</summary> >From issue #<!-- -->73088. I changed `NodeBuilderContext` into a class. >Additionally, there were some other mentions of the former being a struct >which I also changed into a class. This is my first time working with an issue >so I will be open to hearing any advice or changes that need to be done. --- Full diff: https://github.com/llvm/llvm-project/pull/84638.diff 1 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h (+3-2) ``````````diff diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h index 8e392421fef9bb..24d4afc551355e 100644 --- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h +++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h @@ -59,7 +59,7 @@ class CoreEngine { friend class ExprEngine; friend class IndirectGotoNodeBuilder; friend class NodeBuilder; - friend struct NodeBuilderContext; + friend class NodeBuilderContext; friend class SwitchNodeBuilder; public: @@ -194,7 +194,8 @@ class CoreEngine { }; // TODO: Turn into a class. -struct NodeBuilderContext { +class NodeBuilderContext { +public: const CoreEngine &Eng; const CFGBlock *Block; const LocationContext *LC; `````````` </details> https://github.com/llvm/llvm-project/pull/84638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits