================ @@ -337,12 +347,58 @@ CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { return CharUnits::fromQuantity(4); } +ABIArgInfo PPC32_SVR4_ABIInfo::handleComplex(uint64_t &TypeSize) const { + llvm::Type *ElemTy; + unsigned RegsNeeded; // Registers Needed for Complex. + + if (TypeSize == 64) { + ElemTy = llvm::Type::getInt64Ty(getVMContext()); + RegsNeeded = 1; + } else { + ElemTy = llvm::Type::getInt32Ty(getVMContext()); + RegsNeeded = (TypeSize + 31) / 32; + } + return ABIArgInfo::getDirect(llvm::ArrayType::get(ElemTy, RegsNeeded)); +} + +ABIArgInfo PPC32_SVR4_ABIInfo::classifyArgumentType(QualType Ty, + int &ArgGPRsLeft) const { + assert(ArgGPRsLeft <= NumArgGPRs && "Arg GPR tracking underflow"); + Ty = useFirstFieldIfTransparentUnion(Ty); + + ASTContext &Context = getContext(); + + uint64_t TypeSize = Context.getTypeSize(Ty); + + if (IsComplexInRegABI && Ty->isAnyComplexType() && + TypeSize <= RegLen * ArgGPRsLeft) { + assert(Ty->isAnyComplexType() && "Ty must be Complex type."); + ArgGPRsLeft -= TypeSize / RegLen; + return handleComplex(TypeSize); + } + + if (ArgGPRsLeft) { + // Records with non-trivial destructors/copy-constructors should not be + // passed by value. + if (isAggregateTypeForABI(Ty)) + ArgGPRsLeft -= 1; + else if (!Ty->isFloatingType()) { + // For other premitive types. + if (TypeSize > RegLen && TypeSize <= 2 * RegLen) + ArgGPRsLeft -= TypeSize / RegLen; ---------------- diggerlin wrote:
can we change ``` if (TypeSize > RegLen && TypeSize <= 2 * RegLen) ArgGPRsLeft -= TypeSize / RegLen; ``` and what if ArgGPRsLeft =1 and TypeSize == 2 * RegLen. after above code , the ArgGPRsLeft will be -1. is it correct ? it hit assert `assert(ArgGPRsLeft <= NumArgGPRs && "Arg GPR tracking underflow");` when the `classifyArgumentType` is called next time. suggest change to ``` if (TypeSize > RegLen && && TypeSize <= RLen * ArgGPRsLeft) ArgGPRsLeft -= TypeSize / RegLen; ``` and add a test case which can make ArgGPRsLeft to zero; https://github.com/llvm/llvm-project/pull/77732 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits