beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: test/lit.cfg:109 + if not llvm_shlib_dir: + lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) ---------------- mgorny wrote: > beanz wrote: > > Should this really be fatal? It seems to me in many cases you might not > > need this to be set. > I don't mind either way. I left it like this since I really don't see a case > when it could be unset ;-). Ah! You're right. I didn't see where it was getting set. https://reviews.llvm.org/D26115 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits