carlosgalvezp wrote:

Shouldn't we simply `return`?

As you say, the assert is disabled in Release mode. Even if it's enabled, the 
author if `getSubExpr` may one day decide to remove the assert without possibly 
knowing all the places that do rely on that assert, leaving the code 
unprotected. It seems like it's trivial solution to `return` and be on the safe 
side.

https://github.com/llvm/llvm-project/pull/85473
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to