goldsteinn wrote: > Apart from the correctness issues, we've seen some regressions on various > benchmarks from LLVM Test Suite after this patch. Specifically, around 3-5% > regression on x86-64 in various metrics of the > [Interpolation](https://github.com/llvm/llvm-test-suite/tree/main/MicroBenchmarks/ImageProcessing/Interpolation) > benchmarks, and up to 30% regression on a number of floating point-centric > benchmarks from > https://github.com/llvm/llvm-test-suite/tree/main/SingleSource/Benchmarks/Misc > (flops-4.c, flops-5.c, flops-6.c, flops-8.c, fp-convert.c). The numbers vary > depending on the microarchitecture, with Skylake being less affected (on the > order of ~10%) and AMD Rome showing larger regressions (up to 30%).
Thank you for the info, well its reverted now so nothing todo. Although that does motivate me to get re-post with the `nneg` flag support as it sounds like getting the right cast can be important and that will allow us to do a better job than we currently are. https://github.com/llvm/llvm-project/pull/82404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
