================ @@ -418,39 +448,60 @@ static ReadySuspendResumeResult buildCoawaitCalls(Sema &S, VarDecl *CoroPromise, return Calls; } Expr *CoroHandle = CoroHandleRes.get(); - CallExpr *AwaitSuspend = cast_or_null<CallExpr>( - BuildSubExpr(ACT::ACT_Suspend, "await_suspend", CoroHandle)); + auto *AwaitSuspend = [&]() -> CallExpr * { + auto *SubExpr = BuildSubExpr(ACT::ACT_Suspend, "await_suspend", CoroHandle); + if (!SubExpr) + return nullptr; + if (auto *E = dyn_cast<CXXBindTemporaryExpr>(SubExpr)) { + // This happens when await_suspend return type is not trivially + // destructible. This doesn't happen for the permitted return types of + // such function. Diagnose it later. + return cast_or_null<CallExpr>(E->getSubExpr()); + } else { + return cast_or_null<CallExpr>(SubExpr); + } ---------------- ChuanqiXu9 wrote:
I am still concerning the change. What's the type of `SubExpr`? Can we get the return type of SubExpr directly instead of accessing it by CallExpr? https://github.com/llvm/llvm-project/pull/85684 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits