aeubanks wrote:

> We already have similar stuff:
> 
> ```
> if (PGOOpt && Phase != ThinOrFullLTOPhase::ThinLTOPostLink &&
>       !PGOOpt->MemoryProfile.empty())
>     MPM.addPass(MemProfUsePass(PGOOpt->MemoryProfile, PGOOpt->FS));
> ```

checking for ThinLTO pre/post link is a correctness thing though

I think I'm still confused on exactly what the use case is and why we can't 
just ask the user to not specify hwasan in the PGO instrumented build. Just for 
user convenience? Or does clang change the emitted IR when hwasan is enabled? 
And that's what will lead to mismatched profiles?

https://github.com/llvm/llvm-project/pull/86739
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to