zahiraam wrote:

> > Now I wonder if the fix should be with the (void) or without. Have you 
> > tried it locally to see if you get the same build error?
> 
> Yes, I just tried your patch and confirmed that the unit test passes without 
> a problem.
> 
> No, you shouldn't keep `(void)` there. It's there just to silence the warning 
> because the lambda is sitting unused outside the call to 
> `PrintedDeclCXX98Matches`. Once you bring the lambda inside the call to 
> `PrintedDeclCXX98Matches`, the lambda is used, so you shouldn't get a warning.

Perfect! As soon as the testing completes I will merge it in. Thanks.

https://github.com/llvm/llvm-project/pull/86741
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to