https://github.com/PiotrZSL commented:

Overal looks fine.
Try spliting bigger parts of code int some lambdas or functions, so it could be 
more readable, consider adding some 1 line comments specially when fixes are 
created to point out what those insertions/replacement/deletions are.
Check code for missing checks (nullptr, iterators).

In general consider replacing some std::vector with llvm::SmallVector with some 
preallocated memofry, like for 2 or 32 elements, depend on needs

https://github.com/llvm/llvm-project/pull/85572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to