pogo59 wrote:

Thanks for the link back to the Phab review, that was helpful. I didn't offhand 
recall the previous round of this. I'll trust the comments I made on that 
review. :)

s/members/methods/ in the option name to avoid the incorrect implication of 
suppressing data members?

I suggest _not_ omitting methods when generating type sections. If there's only 
one description (in the final executable) it ought to be complete. If you omit 
undefined methods, and the linker picks the section from a CU with no method 
definitions, you end up with a type description that has no methods at all, 
which is not especially useful.

https://github.com/llvm/llvm-project/pull/87018
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to