https://github.com/5chmidti requested changes to this pull request.

Functionality-wise, this looks good to me, I only have some comments regarding 
cleanup.

Please also add tests for min and max calls that are true-negatives, i.e.: 
`std::max(1, 2);`, `std::max({1, 2, 3});` and `std::max({1, 2, 3}, less_than);` 
are probably enough

https://github.com/llvm/llvm-project/pull/85572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to