================ @@ -4429,6 +4433,218 @@ class FunctionNoProtoType : public FunctionType, public llvm::FoldingSetNode { } }; +// ------------------------------------------------------------------------------ + +// TODO: Should FunctionEffect be located elsewhere, where Decl is not +// forward-declared? +class Decl; ---------------- Sirraide wrote:
Not entirely sure what you mean here; imo it’s fine in this file since it’s part of the function type—unless you’re talking about factoring effects out into a separate file entirely, which might be reasonable if the implementation gets too big (but that’s probably not the case now). https://github.com/llvm/llvm-project/pull/84983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits