vangyzen added a comment. In https://reviews.llvm.org/D26979#604013, @EricWF wrote:
> Nope. Feel free to commit after adding the requested assertions. I would gladly commit it, but I don't have commit access. I'm quite new here. ================ Comment at: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65 + { + expected = *std::localeconv()->thousands_sep; + (void) std::setlocale(LC_NUMERIC, "C"); ---------------- EricWF wrote: > We should probably assert that `thousands_sep` isn't a multibyte character. I don't quite follow. C defines it as `char*`. Are you concerned about an implementation defining it as `wchar_t*`? https://reviews.llvm.org/D26979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits