================ @@ -2101,9 +2179,20 @@ bool PragmaClangAttributeSupport::isAttributedSupported( return SpecifiedResult; // Opt-out rules: - // An attribute requires delayed parsing (LateParsed is on) - if (Attribute.getValueAsBit("LateParsed")) + + // An attribute requires delayed parsing (LateParsed is on). + switch (getLateAttrParseKind(&Attribute)) { + case LateAttrParseKind::LateAttrParsingNever: + break; + case LateAttrParseKind::LateAttrParsingAlways: + return false; + case LateAttrParseKind::LateAttrParsingExperimentalOnly: + // FIXME: This is only late parsed when + // `-fexperimental-late-parse-attributes` is on. If that option is off + // then we shouldn't return here. return false; ---------------- Sirraide wrote:
I’d leave a comment here explaining the situation; I’m just saying that I’m not convinced there really is any ‘fixing’ this here w/o making the code around `IsSupportedByPragmaAttribute` aware of this, which seems like a strange thing to do. https://github.com/llvm/llvm-project/pull/88596 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits