ioeric added inline comments.
================
Comment at: clang-move/ClangMove.h:90
+
+// When moving all declarations in old header, all code in old.h/cc will be
+// moved.
----------------
Is this the right place for this comment? Seems a bit unexpected.
================
Comment at: unittests/clang-move/ClangMoveTests.cpp:522
+ auto ExpectedDeclaration = ExpectedDeclarations.begin();
+ for (auto DeclPair : Reporter.getDeclarationList()) {
+ ASSERT_TRUE(ExpectedDeclaration != ExpectedDeclarations.end());
----------------
What if `Reporter.getDeclarationList().size()` > `ExpectedDeclaration.size()`.
I'd use iterator-based loop on both vectors and assert both iterators reached
end after loop.
https://reviews.llvm.org/D27059
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
