yxsamliu wrote: > Isn't this ABI breaking since we're changing the size of the struct? > Shouldn't that necessitate a new version? > > Also unrelated, I wonder if there's a future where we can use the > ClangOffloadPackager format in the HIP runtime.
I think you are right. Although this feature has not been used extensively, it is better to bump up the version to keep backward compatibility. Currently we are moving the extraction of code object from fat binary from runtime to comgr. We can treat the offload packager format as another flavor of fat binary. We only need to pass a pointer to sufficient information to __hipRegisterFatBinary, and let runtime pass that pointer to comgr, then comgr do the extraction. comgr just needs to identify it is offload packager format and handle it properly. https://github.com/llvm/llvm-project/pull/88827 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
