yaron.keren added inline comments.

================
Comment at: lib/AST/ASTContext.cpp:8258
       return RHS;
-    return isa<ReadPipeType>(LHS) ? getReadPipeType(ResultType)
-                                  : getWritePipeType(ResultType);
+    const PipeType *PT = LHS->getAs<PipeType>();
+    return PT->isReadOnly() ? getReadPipeType(ResultType)
----------------
I'm not too familar how PipeTypes should be merged, is it on purpose the 
process is not commutative,

ReadPipeType merged with WritePipeType is ReadPipeType

WritePipeType merged with ReadPipeType is WritePipeType 



Repository:
  rL LLVM

https://reviews.llvm.org/D27049



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to