================
@@ -1293,6 +1293,10 @@ compileModuleImpl(CompilerInstance &ImportingInstance, 
SourceLocation ImportLoc,
                                             diag::remark_module_build_done)
     << ModuleName;
 
+  // Propagate the statistics to the parent FileManager.
+  if (FrontendOpts.ModulesShareFileManager)
----------------
jansvoboda11 wrote:

Shouldn't this condition be inverted? When 
`FrontendOpts.ModulesShareFileManager == true`, I'd expect 
`&ImportingInstance.getFileManager() == &Instance.getFileManager()`. Maybe we 
can have an assertion in `FileManager::AddStats()` that would catch this.

https://github.com/llvm/llvm-project/pull/88427
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to