https://github.com/5chmidti requested changes to this pull request.
I started taking a look at this and realized you switched up which argument matcher needs the extra `ignoringParenImpCasts`, so that it can be removed from the matcher definition. See https://github.com/llvm/llvm-project/blob/d674f45d51bffbba474b12e07f7d57a2390d2f31/clang/include/clang/ASTMatchers/ASTMatchers.h#L4891-L4907 vs https://github.com/llvm/llvm-project/blob/d674f45d51bffbba474b12e07f7d57a2390d2f31/clang/include/clang/ASTMatchers/ASTMatchers.h#L4553-L4564. We don't want the `IgnoreParenImpCasts()` inside the `hasArgument` matcher, because that is not it's job. So we want to a) add `ignoringParenImpCasts` to arguments of the `hasArgument` matcher, and b) remove the call to `IgnoreParenImpCasts` from the `hasArgument` matcher. See this comment from the original issue: https://github.com/llvm/llvm-project/issues/75754#issuecomment-1887818096 This is also the reason why the tests are failing, you are actually changing the behavior of these checks. https://github.com/llvm/llvm-project/pull/89509 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
