kromanenkov marked an inline comment as done. kromanenkov added inline comments.
================ Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:217 + + llvm::ImmutableList<const CXXBaseSpecifier *> consCXXBase( + const CXXBaseSpecifier *CBS, ---------------- NoQ wrote: > Hmm, is it "construct"? Or "constrain"? I think a verbose name wouldn't hurt. > In fact, i suspect that `consVals` are rather `conSVals`, where `con` stands > for "concatenate". In fact I thought that this entails "consume" :) ================ Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:882 + return UndefinedVal(); + if (const FieldDecl *FD = PTMSV->getDeclAs<FieldDecl>()) + return state->getLValue(FD, lhs); ---------------- NoQ wrote: > Hmm, do we need to cover `CXXMethodDecl` here? Or is it modeled as a function > pointer anyway, so no action is needed? Worth commenting, i think. AFAIU CXXMethodDecl is processed in SVal::getAsFunctionDecl() so i'm for no action. https://reviews.llvm.org/D25475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
