================
@@ -4372,6 +4372,13 @@ def HLSLResourceBinding: InheritableAttr {
   let Documentation = [HLSLResourceBindingDocs];
 }
 
+def HLSLPackOffset: HLSLAnnotationAttr {
+  let Spellings = [HLSLAnnotation<"packoffset">];
+  let LangOpts = [HLSL];
+  let Args = [IntArgument<"Offset">];
----------------
llvm-beanz wrote:

Looking at this more this seems really weird to me. The argument isn't actually 
an integer, it's a special string. You're parsing it to an integer, but that 
actually loses some fidelity.

We should probably store index and sub-component values in the attribute rather 
than collapsing it down into one value.

https://github.com/llvm/llvm-project/pull/89836
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to