================
@@ -1,5 +1,37 @@
+// RUN: %clang -### -c --target=aarch64 %s 2>&1 | FileCheck %s --check-prefix 
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-
+
 // RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics 
-fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
 // INTRIN: "-cc1"{{.*}} "-fptrauth-intrinsics"
 
-// RUN: not %clang -### -c --target=x86_64 -fptrauth-intrinsics %s 2>&1 | 
FileCheck %s --check-prefix=ERR
-// ERR: error: unsupported option '-fptrauth-intrinsics' for target '{{.*}}'
+// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-calls -fptrauth-calls %s 
2>&1 | FileCheck %s --check-prefix=CALL
----------------
kovdan01 wrote:

I've measured timings on my machine, and we can potentially save about 0.1s if 
combine some of the RUN lines. It's noticeable, but there are tests like 
aarch64-fixed-x-register.c which contain a lot more similar RUN lines which can 
also be combined and we could save even more if enhance them.

I suggest to merge this PR "as is" and probably submitting a subsequent PR 
which makes this test and some similar ones "lighter" if it's a big concern. As 
for me, keeping all the RUN lines can protect us from dummy typos and they 
probably are worth the time spent on them - but I don't mind combining the RUN 
lines if the extra overhead bothers many people.

Please let me know if this approach is OK for you and I can merge the PR. If 
the clang driver test timings look too bad, I can also submit a corresponding 
issue so the context of the discussion is not lost.



https://github.com/llvm/llvm-project/pull/85235
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to