dwblaikie wrote:

Presumably this'll be split out into separate reviews for the components here? 
(I'd guess llvm-mc then clang integrated assembler, with readobj and yaml2obj 
in any order/don't have dependencies, unless they're needed for testing, in 
which case I guess they come first?)

I hesitate to comment on the specifics while it's all together as I imagine 
it'll become hard to follow the different commentary across the larger 
patch/different project areas, etc.

(though the flag design seems strange to me - having --crel and 
--experimental-crel, rather than having only the latter (and renaming it in the 
future, rather than using two flags now and removing one in the future))



https://github.com/llvm/llvm-project/pull/91280
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to