Jim M. R. =?utf-8?q?Teichgräber?=,Jim M. R. =?utf-8?q?Teichgräber?Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/91...@github.com>
AaronBallman wrote: > > Please be sure to add a release note to clang/docs/ReleaseNotes.rst so > > users know about the fix. > > Oh, sorry, I didn't find anything know how release notes were handled - will > do! No worries! > A question on that, would you classify this as a breaking change? > Technically, it could break the compilation of programs previously compiled > with Clang 17 that compile VLA type compound literals, but never execute the > code that they're used in; is that enough for it to be listed as a breaking > change? If so, would this go under the `C/C++ Language Potentially Breaking > Changes` header? Or should I create a new `C Language Potentially Breaking > Changes` header, as this does not affect Clang's C++ behavior itself in any > way? Nope -- potentially breaking changes are ones that are likely to be significantly disruptive, but I suspect very few folks will have code suddenly rejected as a result of your fix. > PS: I hope multiple commits in this PR are fine, they are squashed in the end > anyway, right? Totally fine! https://github.com/llvm/llvm-project/pull/91891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
