bkramer added inline comments.
================
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:90
+ // extern "C" globals need to be in the global namespace.
+ if (VDecl->isExternC())
+ return;
----------------
alexfh wrote:
> Is this already filtered-out by the matcher?
Nope.
================
Comment at: clang-tidy/google/GoogleTidyModule.cpp:68
+ CheckFactories.registerCheck<readability::GlobalNamesCheck>(
+ "google-global-names");
CheckFactories.registerCheck<clang::tidy::readability::FunctionSizeCheck>(
----------------
aaron.ballman wrote:
> Given that this was shipped under the old name, I think we need to figure out
> our policy for how to handle this. It also comes up in D26511, so I would
> like us to be consistent with what we do.
There was no special handling in D26511, so I left this as-is.
https://reviews.llvm.org/D23130
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
