probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 + InitExpr = + DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue()); GV.reset(DBuilder.createGlobalVariable( ---------------- dgross wrote: > probinson wrote: > > This line exceeds 80 columns. clang-format is your friend. > Done. Is clang-format mentioned in any of the documentation that describes > the development process? I might have missed it (not that that's an excuse > for a needless violation of the coding guidelines). I would have thought the coding guidelines would mention clang-format, but I'm not finding it there (or in the stuff about submitting a patch). https://reviews.llvm.org/D27549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
