rsmith added inline comments.
================ Comment at: lib/Lex/PPMacroExpansion.cpp:110-112 + // FIXME: shouldIgnoreMacro() in ASTWriter also stops at macros from the + // predefines buffer in module builds. Do we need to splice to those here + // too? ---------------- If I remember correctly, we shouldn't need to; we run this step before we start lexing the predefines buffer. However, that does mean that macros on the command line will *override* macros from the PCH, which seems like it's probably the wrong behavior... https://reviews.llvm.org/D27545 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
